changeset 4:48f25b8408e1 draft

planemo upload commit 18df9e67efd4adafcde4eb9b62cd815e4afe9733-dirty
author iuc
date Wed, 26 Aug 2015 14:37:18 -0400
parents bb65623b90a8
children e16d8e6654a6
files imagej2_base_utils.py imagej2_create_image.py imagej2_create_image.xml imagej2_macros.xml
diffstat 4 files changed, 22 insertions(+), 47 deletions(-) [+]
line wrap: on
line diff
--- a/imagej2_base_utils.py	Tue Aug 04 11:15:10 2015 -0400
+++ b/imagej2_base_utils.py	Wed Aug 26 14:37:18 2015 -0400
@@ -86,21 +86,6 @@
     os.symlink( input_file, image_path )
     return image_path
 
-def get_max_heap_size_value( max_heap_size_type, max_heap_size ):
-    """
-    Return a string that can be used by the javabridge to set the size
-    of the memory allocation pool used by the JVM.  The value must be
-    determined to be a multiple of 1024 or it will be ignored.
-    """
-    if max_heap_size_type == 'default':
-        return None
-    if max_heap_size_type == 'megabytes':
-        if int( max_heap_size ) % 1024 not in [ 0, 256, 512 ]:
-            return None
-        return '%sm' % str( max_heap_size )
-    if max_heap_size_type == 'gigabytes':
-        return '%sg' % str( max_heap_size )
-
 def get_platform_info_dict():
     '''Return a dict with information about the current platform.'''
     platform_dict = {}
@@ -172,6 +157,7 @@
             return ' %.1f' % val
         elif val_type == 'int':
             return ' %d' % val
+    return ' %s' % val
 
 def stop_err( msg ):
     sys.stderr.write( msg )
--- a/imagej2_create_image.py	Tue Aug 04 11:15:10 2015 -0400
+++ b/imagej2_create_image.py	Wed Aug 26 14:37:18 2015 -0400
@@ -13,8 +13,6 @@
     parser.add_argument( '--depth', dest='depth', type=int, help='Image depth (specifies the number of stack slices)' )
     parser.add_argument( '--image_type', dest='image_type', help='Image type' )
     parser.add_argument( '--image_title', dest='image_title', default='', help='Image title' )
-    parser.add_argument( '--max_heap_size_type', dest='max_heap_size_type', help='Type (default or megabytes) of max_heap_size value' )
-    parser.add_argument( '--max_heap_size', dest='max_heap_size', help='Maximum size of the memory allocation pool used by the JVM.' )
     parser.add_argument( '--output_datatype', dest='output_datatype', help='Output image format' )
     parser.add_argument( '--jython_script', dest='jython_script', help='Path to the Jython script' )
     parser.add_argument( '--out_fname', help='Path to the output file' )
@@ -22,8 +20,6 @@
 
     tmp_dir = imagej2_base_utils.get_temp_dir()
     tmp_image_path = imagej2_base_utils.get_temporary_image_path( tmp_dir, args.output_datatype )
-    # Set the size of the memory allocation pool used by the JVM.
-    memory_size = imagej2_base_utils.get_max_heap_size_value( args.max_heap_size_type, args.max_heap_size )
 
     # Define command response buffers.
     tmp_out = tempfile.NamedTemporaryFile().name
@@ -31,7 +27,7 @@
     tmp_err = tempfile.NamedTemporaryFile().name
     tmp_stderr = open( tmp_err, 'wb' )
     # Build the command line.
-    cmd = imagej2_base_utils.get_base_command_imagej2( memory_size, jython_script=args.jython_script )
+    cmd = imagej2_base_utils.get_base_command_imagej2( None, jython_script=args.jython_script )
     if cmd is None:
         imagej2_base_utils.stop_err( "ImageJ not found!" )
     cmd += ' %s %d %d %d %s %s' % ( args.image_title, args.width, args.height, args.depth, args.image_type, tmp_image_path )
--- a/imagej2_create_image.xml	Tue Aug 04 11:15:10 2015 -0400
+++ b/imagej2_create_image.xml	Wed Aug 26 14:37:18 2015 -0400
@@ -1,10 +1,10 @@
 <?xml version='1.0' encoding='UTF-8'?>
-<tool id="imagej2_create_image" name="Create new image" version="1.0.0">
+<tool id="imagej2_create_image" name="Create new image" version="@WRAPPER_VERSION@.0">
     <description>with ImageJ2</description>
     <macros>
         <import>imagej2_macros.xml</import>
     </macros>
-    <expand macro="fiji_20141125_requirements" />
+    <expand macro="fiji_requirements" />
     <command>
 <![CDATA[
     python $__tool_directory__/imagej2_create_image.py
@@ -13,7 +13,6 @@
     --depth $depth
     --image_type $image_type
     --image_title "$image_title"
-    @max_heap_size_args@
     --jython_script $__tool_directory__/jython_script.py
     --output_datatype $output_datatype
     --out_fname "$output"
@@ -28,7 +27,6 @@
         <param name="output_datatype" type="select" label="Save as format">
             <expand macro="image_datatypes" />
         </param>
-        <expand macro="max_heap_size_type_conditional" />
     </inputs>
     <outputs>
         <data name="output" format="jpg">
--- a/imagej2_macros.xml	Tue Aug 04 11:15:10 2015 -0400
+++ b/imagej2_macros.xml	Wed Aug 26 14:37:18 2015 -0400
@@ -1,11 +1,12 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <macros>
-    <xml name="fiji_20141125_requirements">
+    <token name="@WRAPPER_VERSION@">1.0</token>
+    <xml name="fiji_requirements">
         <requirements>
             <requirement type="package" version="20141125">fiji</requirement>
         </requirements>
     </xml>
-    <xml name="python_bioformats_104_requirements">
+    <xml name="python_bioformats_requirements">
         <requirements>
             <requirement type="package" version="20141125">fiji</requirement>
             <requirement type="package" version="1.0.11">javabridge</requirement>
@@ -53,33 +54,27 @@
             <option value="yes">Yes</option>
         </param>
     </xml>
+    <xml name="black_background_param">
+        <param name="black_background" type="select" label="Black background" help="If Yes, the background is black and the foreground is white (no implies the opposite).">
+            <option value="no" selected="True">No</option>
+            <option value="yes">Yes</option>
+        </param>
+    </xml>
     <token name="@make_binary_args@">
         --iterations $iterations
         --count $count
         --black_background $black_background
         --pad_edges_when_eroding $pad_edges_when_eroding
     </token>
-    <xml name="max_heap_size_type_conditional">
-        <conditional name="set_max_heap_size">
-            <param name="max_heap_size_type" type="select" label="Maximum size of the memory allocation pool used by the JVM" help="This value must be a multiple of 1024 or it will be ignored and the system default will be used.">
-                <option value="default" selected="True">Do not set</option>
-                <option value="megabytes">Set in megabytes</option>
-                <option value="gigabytes">Set in gigabytes</option>
-            </param>
-            <when value="default" >
-                <param name="max_heap_size" type="integer" value="0" hidden="true" label="Do not set" help="Use system default"/>
-            </when>
-            <when value="megabytes">
-                <param name="max_heap_size" type="integer" value="512" min="256" label="Maximum size, in megabytes, of the memory allocation pool" help="Examples: 256, 512, etc."/>
-            </when>
-            <when value="gigabytes">
-                <param name="max_heap_size" type="integer" value="1" min="1" label="Maximum size, in gigabytes, of the memory allocation pool" help="Examples: 1, 2, etc."/>
-            </when>
-        </conditional>
-    </xml>
-    <token name="@max_heap_size_args@">
-        --max_heap_size_type $set_max_heap_size.max_heap_size_type
-        --max_heap_size $set_max_heap_size.max_heap_size
+    <token name="@requires_binary_input@">
+.. class:: warningmark
+
+This tool works on binary images, so other image types will automatically be converted to binary
+before they are analyzed.  This step is performed using the ImageJ2 **Make Binary** command with
+the following settings: **Iterations:** 1, **Count:** 1, **Pad edges when eroding:** No.  The tool
+allows you to choose the **Black background** setting.  If these settings are not appropriate,
+first manually convert the image to binary using the **Convert to binary (black and white) with ImageJ2**
+tool, which allows you to change them.
     </token>
     <xml name="image_datatypes">
         <option value="bmp">bmp</option>