changeset 4:bdd6c1ab07c5 draft

planemo upload for repository https://github.com/jvolkening/galaxy-tools/tree/master/tools/nanopolish commit 83364d7d78ca5524a08065daef995bfcd54a379d
author jdv
date Fri, 01 Dec 2017 21:22:01 -0500
parents a1d433401bc2
children ee4a11ebe451
files nanopolish_variants.pl nanopolish_variants.xml
diffstat 2 files changed, 12 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/nanopolish_variants.pl	Sat Oct 14 00:05:43 2017 -0400
+++ b/nanopolish_variants.pl	Fri Dec 01 21:22:01 2017 -0500
@@ -4,7 +4,6 @@
 use warnings;
 use 5.012;
 
-use Archive::Tar;
 use Cwd qw/getcwd abs_path/;
 use File::Copy qw/copy/;
 use Getopt::Long qw/:config pass_through/;
@@ -31,25 +30,31 @@
     'reads=s'     => \$fn_reads,
 );
 
+my $ret;
+
 my $tmp_dir = 'tmp_dir';
 mkdir $tmp_dir;
 
 $fn_fast5 = abs_path($fn_fast5);
 
 # extract FAST5 files to path where they are expected
+# use system 'tar' to transparently and safely handle absolute paths
 my $fast5_dir = 'fast5';
 mkdir $fast5_dir;
 my $cwd = abs_path( getcwd() );
 chdir $fast5_dir;
-my $tar = Archive::Tar->new();
-$tar->read($fn_fast5);
-$tar->extract();
-say "done extracting $fn_fast5 here";
+$ret = system(
+    'tar',
+    '-xvf',
+    $fn_fast5
+);
+die "Failed to extract tarball: $!\n"
+    if ($ret);
 chdir $cwd;
 
 
 # index reads
-my $ret = system(
+$ret = system(
     'nanopolish',
     'index',
     '--directory' => $fast5_dir,
--- a/nanopolish_variants.xml	Sat Oct 14 00:05:43 2017 -0400
+++ b/nanopolish_variants.xml	Fri Dec 01 21:22:01 2017 -0500
@@ -69,6 +69,7 @@
     <!-- ***************************************************************** -->
 
     <tests>
+        <!-- TODO -->
     </tests>
 
     <!-- ***************************************************************** -->